Closed mfschubert closed 8 months ago
Does this resolve any of the power conservation issues you were seeing?
Does this resolve any of the power conservation issues you were seeing?
No it is unrelated. For issues related to power conservation I expect that improved s-matrix treatment will be needed.
This PR is a further step to addressing https://github.com/facebookresearch/fmmax/issues/55
The hyperparameters (smoothness loss weight and fourier loss weight) were adjusted to achieve good convergence of simulated quantities with the number of Fourier terms in the expansion. For the uLED, this new implementation gives essentially unchanged results when compared to the earlier implementation (see figure).
The old implementations still remain in the code; these should be removed in a follow-up PR.