Adding efficiency, visualization, and convergency tests to dipole.ipynb.

facebookresearch / fmmax

Fourier modal method with Jax

MIT License

95 stars 9 forks source link

Adding efficiency, visualization, and convergency tests to dipole.ipynb. #85

Closed Luochenghuang closed 7 months ago

Luochenghuang commented 7 months ago

This is an attempt to complete the dipole.ipynb notebook. Please let me know there are mistakes. Thank you!

Luochenghuang commented 7 months ago

Apparently there is a bug where if you include output images in the .ipynb then the docs build fails because the pipeline doesn't save the images. It's should be fixed now.

smartalecH commented 7 months ago

(Also, thanks for fixing that bug with the image output)

Luochenghuang commented 7 months ago

Thank you for reviewing!