fix pypi package release - Githubissues

facebookresearch / fvcore

Collection of common code that's shared among different research projects in FAIR computer vision team.

Apache License 2.0

2k stars 226 forks source link

fix pypi package release #101

Closed ppwwyyxx closed 2 years ago

ppwwyyxx commented 2 years ago

The pypi package https://pypi.org/project/fvcore/ has not been updated for a while. This is because CI creates package with invalid name, e.g. https://app.circleci.com/pipelines/github/facebookresearch/fvcore/920/workflows/651c790b-758d-4fa0-9471-3317d0280868/jobs/3059/parallel-runs/0/steps/0-106 has fvcore-0.1.5.post20220106.post20220106.post20220106/.

The name is now normal with this commit, shown in https://app.circleci.com/pipelines/github/facebookresearch/fvcore/921/workflows/cb411117-6c4a-48b8-b5d0-486322b0d952/jobs/3064.

The gpu tests are failing due to pre-existing docker error (there is an internal task on it).

ppwwyyxx commented 2 years ago

@haooooooqi @lyttonhao @ericmintun could you help merge this?

facebook-github-bot commented 2 years ago

@lyttonhao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

lyttonhao commented 2 years ago

Thanks for the fix. Looks good to me! Waiting for the review.

ppwwyyxx commented 2 years ago

Any updates?