Closed wat3rBro closed 1 year ago
This pull request was exported from Phabricator. Differential Revision: D41145857
This pull request was exported from Phabricator. Differential Revision: D41145857
This pull request was exported from Phabricator. Differential Revision: D41145857
Thanks a lot for doing this! I think you'd have to bump the version number and let detectron2 depend on this version of fvcore.
Also, new versions of fvcore get published to pypi automatically through circleci, only if cpu/gpu tests passed.. Unfortunately, tests have been broken for many months, so that's another dependency.. :cry:
An alternative is to overwrite .load()
in detectron2 so you can leave fvcore as is
This pull request was exported from Phabricator. Differential Revision: D41145857
This pull request was exported from Phabricator. Differential Revision: D41145857
This pull request was exported from Phabricator. Differential Revision: D41145857
This pull request has been merged in facebookresearch/fvcore@d194d76a30b634cc200195252975df3a0eb98a67.
Summary: D35519683 changed the default
matching_heuristics
fromFalse
toTrue
, it may cause some issues:This diff reverts the default value back to
False
, and introduce a way to specify this option via filename url.Differential Revision: D41145857