facebookresearch / fvcore

Collection of common code that's shared among different research projects in FAIR computer vision team.
Apache License 2.0
1.93k stars 226 forks source link

support specifying matching_heuristics from filename #118

Closed wat3rBro closed 1 year ago

wat3rBro commented 1 year ago

Summary: D35519683 changed the default matching_heuristics from False to True, it may cause some issues:

This diff reverts the default value back to False, and introduce a way to specify this option via filename url.

Differential Revision: D41145857

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41145857

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41145857

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41145857

ppwwyyxx commented 1 year ago

Thanks a lot for doing this! I think you'd have to bump the version number and let detectron2 depend on this version of fvcore.

Also, new versions of fvcore get published to pypi automatically through circleci, only if cpu/gpu tests passed.. Unfortunately, tests have been broken for many months, so that's another dependency.. :cry:

ppwwyyxx commented 1 year ago

An alternative is to overwrite .load() in detectron2 so you can leave fvcore as is

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41145857

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41145857

facebook-github-bot commented 1 year ago

This pull request was exported from Phabricator. Differential Revision: D41145857

facebook-github-bot commented 1 year ago

This pull request has been merged in facebookresearch/fvcore@d194d76a30b634cc200195252975df3a0eb98a67.