search

facebookresearch / goliath

Goliath Dataset and Official PyTorch Implementation of RelightableHands, Relightable Gaussian Codec Avatars, and Driving-Signal Aware Full-Body Avatars.
Other
207 stars 15 forks source link

Completed URHand Release #16

Closed FrozenBurning closed 2 months ago

FrozenBurning commented 2 months ago

This PR contains the release of the training code for the paper, Universal Relightable Hands. On top of the previous PR (https://github.com/facebookresearch/goliath/pull/15), we can correctly incorporate the shadow map and a script for getting mean texture. Now, it is ready to be merged into the main branch.

Meanwhile, it would be great to update the repo description from "Goliath Dataset and Official PyTorch Implementation of RelightableHands, Relightable Gaussian Codec Avatars, and Driving-Signal Aware Full-Body Avatars." -> "Goliath Dataset and Official PyTorch Implementation of RelightableHands, Relightable Gaussian Codec Avatars, URHand, and Driving-Signal Aware Full-Body Avatars."

una-dinosauria commented 2 months ago

Thanks for your contribution! To make it easier to give meaningful feedback, would you mind splitting this PR into smaller ones? I think one way to do this could be:

  1. Everything but urhand.py
  2. Some parts of urhand.py, for example, the models, under ca_code/models/
  3. The rest

Thank you,

FrozenBurning commented 2 months ago

Noted @una-dinosauria . I've split them into three PRs as shown below, which could be merged separately into the main branch.