facebookresearch / gtn

Automatic differentiation with weighted finite-state transducers.
MIT License
453 stars 40 forks source link

A simple collab example #23

Closed vineelpratap closed 3 years ago

vineelpratap commented 3 years ago

Collab link here

Screen Shot 2020-10-06 at 3 17 39 AM
awni commented 3 years ago

Awesome, thanks for adding this!

How should we keep track of notebooks, does it make sense to put them in version control? (e.g. docs/notebooks or something like that?)

Notebook nits: -could you use the same variable names as in the quickstart code (e.g. score and intersection). -clear the last unused cell

jacobkahn commented 3 years ago

Agree — we should definitely version control this if we can.

awni commented 3 years ago

LGTM!