search

facebookresearch / gtn

Automatic differentiation with weighted finite-state transducers.
MIT License
453 stars 40 forks source link

crf notebook and complete example #26

Closed awni closed 3 years ago

awni commented 3 years ago

A linear chain crf notebook and example.

jacobkahn commented 3 years ago

Do we want to commit a more minimal .ipynb - maybe one that doesn't have cells that have already all been run?

danpovey commented 3 years ago

I think it's helpful to include cells that have been run-- more instructive.

On Wed, Oct 14, 2020 at 2:41 AM Jacob Kahn notifications@github.com wrote:

Do we want to commit a more minimal .ipynb - maybe one that doesn't have cells that have already all been run?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/facebookresearch/gtn/pull/26#issuecomment-707935092, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZFLOYCXUXVIJLLJRHIC2LSKSNOXANCNFSM4SNKLBPQ .

awni commented 3 years ago

I agree, I think we should keep the cells. Then it will render properly in GitHub and can be read without needing to run it. (It's not working properly right now for some reason, I'll need to investigate this).