facebookresearch / gtn

Automatic differentiation with weighted finite-state transducers.
MIT License
453 stars 38 forks source link

MSVC and Windows support #32

Closed jacobkahn closed 4 years ago

jacobkahn commented 4 years ago

Fix barriers to compiling on Windows with MSVC -- tested with MSVC 2019. These include:

Several operations on Graph use the std::vector::size, as do indices -- using int for these makes overflow possible. This changes many but not all instances of these implicit casts.

All tests pass.