search

facebookresearch / gtn

Automatic differentiation with weighted finite-state transducers.
MIT License
453 stars 38 forks source link

Refactoring compose function #36

Closed shubho closed 3 years ago

awni commented 3 years ago

Thanks for refactoring @shubho, this looks great!

awni commented 3 years ago

Feel free to land the refactor..(I assume tests are passing?) Also might be good to run the timing benchmarks just to be sure nothing changed there. Relevant ones are:

./benchmarks/benchmark_functions

and

./benchmarks/benchmark_ctc

shubho commented 3 years ago

It seems I don't have land permission - can any of the folks with write access land? I want to add a CPU only data parallel implementation on top - so want to land this one first