--[BE Week] Better Attributes Handle search efficiency; Viewer.cpp/Viewer.py text render fixes - Githubissues

facebookresearch / habitat-sim

A flexible, high-performance 3D simulator for Embodied AI research.

https://aihabitat.org/

MIT License

2.54k stars 414 forks source link

--[BE Week] Better Attributes Handle search efficiency; Viewer.cpp/Viewer.py text render fixes #2279

Closed jturner65 closed 8 months ago

jturner65 commented 9 months ago

Motivation and Context

This PR leverages the recent updates to our Magnum libs to address some inefficiencies and bugs, and fixes a minor bug with how scene instances were being loaded.

Viewer.cpp/Viewer.py :

Improve text rendering in the viewers by using the magnum's new glyph handling.
Fix the black-box background around text in viewer.py by enabling, defining and subsequently disabling the appropriate blend state when text is being drawn.

Attributes

Speed up string handle match search by checking size of target string before forcing it to lowercase
Add missing Articulated Object Attributes verification on Scene Instance load to be consistent with Stage, Object and Lighting Attributes handling.

How Has This Been Tested

Locally all tests pass

Types of changes

[x] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.