Remove RTLD_GLOBAL flag from apps. - Githubissues

facebookresearch / habitat-sim

A flexible, high-performance 3D simulator for Embodied AI research.

https://aihabitat.org/

MIT License

2.54k stars 414 forks source link

Remove RTLD_GLOBAL flag from apps. #2312

Closed 0mdc closed 5 months ago

0mdc commented 7 months ago

Motivation and Context

This removes the RTLD_GLOBAL flag from python apps, which is no longer required since this magnum update.

The flag is also set in habitat-sim's __init__.py to handle cases where habitat-sim bindings are used before magnum/corrade is imported.

This flag was required before loading native magnum/habitat modules to de-duplicate globals across shared modules. This is now done automatically when importing corrade..

This PR does the same changes in habitat-lab.

How Has This Been Tested

Tested the viewers locally on Linux.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

0mdc commented 5 months ago

FYI - this breaks usage of magnum importers from outside habitat-sim. There only one instance of this, which is the following: https://github.com/facebookresearch/habitat-lab/blob/main/habitat-lab/habitat/datasets/rearrange/samplers/receptacle.py#L528

We're either going to drop support of PLY or move that function to sim. Until then, this PR will stay open.

FYI @jturner65 , @aclegg3

Edit: This is fixed here: https://github.com/facebookresearch/habitat-lab/pull/1869