--[CI Fix] Fix miniconda versions

jturner65 commented 4 months ago

Motivation and Context

Using the latest miniconda versions is referencing python 3.12 which is undesirable, and causes osx builds to break (pkgutil.ImpImporter class was deprecated in python 3.3 and removed in 3.12.)

This PR will freeze our miniconda version to most recent python 3.10 version for both linux and mac.

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

jturner65 commented 4 months ago

LGTM!

We'll probably want to extend support to Python 3.12 in the foreseeable future.

Yeah, definitely (supposed to be markedly faster with strings, for instance), but it will certainly require a some investigation and reworking since there are many modules that have been deprecated for a while that were removed with 3.11 and 3.12.

aclegg3 commented 4 months ago

Thanks for investigating and fixing this. :+1:

facebookresearch / habitat-sim