Revert "Remove RTLD_GLOBAL flag from apps. (#2312) - Githubissues

facebookresearch / habitat-sim

A flexible, high-performance 3D simulator for Embodied AI research.

https://aihabitat.org/

MIT License

2.48k stars 406 forks source link

Revert "Remove RTLD_GLOBAL flag from apps. (#2312) #2342

Closed 0mdc closed 4 months ago

0mdc commented 4 months ago

Motivation and Context

This reverts commit d890c644a35cefdde1d0962b3e16ecc4f1dd326d (#2312), which is causing downstream issues (for instance, in habitat-llm).

The downstream issues will be stabilized prior to re-introducing this change.

How Has This Been Tested

N/A

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

0mdc commented 4 months ago

I guess we'll have to revert this PR too for lab.

No, it's not necessary.

The RTLD_GLOBAL magic is now done when doing import corrade (or magnum, which imports corrade).