--Bugfix : Expand absolute-to-relative filepath mapping rigor - Githubissues

facebookresearch / habitat-sim

A flexible, high-performance 3D simulator for Embodied AI research.

https://aihabitat.org/

MIT License

2.45k stars 404 forks source link

--Bugfix : Expand absolute-to-relative filepath mapping rigor #2400

Closed jturner65 closed 1 month ago

jturner65 commented 1 month ago

Motivation and Context

This PR addresses some edge case situations that might arise when absolute filepaths are made relative to other paths.

It also substantially expands the tests of this functionality.

How Has This Been Tested

Locally c++ and python tests pass

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have completed my CLA (see CONTRIBUTING)
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.