Closed Gizzio closed 1 year ago
Hi @Gizzio!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
I think it should be compatible, but I am not sure
I think it should be compatible, but I am not sure
Okay - happy to merge if you fix the tests/lint errors :)
Thank you for fixing this! @danthe3rd is it a planned release to pip soon? Or would it be possible to get a pre-release with this fix?
Hum I would need to spend some time to fix the CI... I'll be quite busy in the coming months but I can try to do that if I get some bandwidth
Great, thank you!
Fixes #273