odelalleau
commented
9 months ago I suspect this is indeed a bug / unsupported case, thanks for reporting it.
Open Northo opened 9 months ago
odelalleau
commented
9 months ago I suspect this is indeed a bug / unsupported case, thanks for reporting it.
FrenkT
commented
1 month ago Found the same issue, thanks for raising.
🐛 Bug
Description
Following the pattern of Selecting multiple configs from a Config Group, the behavior of tilde (~) is unexpected; I am not able to evaluate if this is a bug or a lack in the documentation.
When having multiple choices selected in the Defaults List, we cannot remove them with the
~db,~db=mysql,~server/db,~server/db=mysqlsyntax, described here.Checklist
To reproduce
Minimal Code/Config snippet to reproduce
Consider a config layout (where
fb.yamlandgoogle.yamlare as described in the docs)and
When running with CLI overrides
~site=fb, defaults list is cleared and config is an empty dict.However, consider
When running with CLI overrides
~site=fb, we gethydra.errors.ConfigCompositionException: Could not delete 'site=fb'. No match in the defaults list.Full stacktrace
``` Traceback (most recent call last): File "/wd/src/main.py", line 9, inSimilarly,
~site/fbgiveshydra.errors.ConfigCompositionException: Could not delete from config. 'site/fb' does not exist.and~sitegiveshydra.errors.ConfigCompositionException: Could not delete 'site'. No match in the defaults list.I am able to clear the defaults list for it by
site=[], however, I'd like to also understand the ~ operator in this situation.Expected Behavior
Appropriate application of the tilde operator should clear one element of the site group or all the entries of the site group. If this is not intended behavior, this should be documented explicitly either on the Selecting multiple configs from a Config Group page or override grammar page.
System information
hydra-core 1.3.23.12.0Let me know if you require further clarifications.
Additional context
For convenience, output of
--info allfor the two scenarios are here:Defaults with choice as list (`site: [fb]`)
```yaml # config.yaml defaults: - site: - fb - _self_ ``` gives ``` Hydra 1.3.2 =========== Installed Hydra Plugins *********************** ConfigSource: ------------- FileConfigSource ImportlibResourcesConfigSource StructuredConfigSource CompletionPlugin: ----------------- BashCompletion FishCompletion ZshCompletion Launcher: --------- BasicLauncher Sweeper: -------- BasicSweeper Config search path ****************** | Provider | Search path | ------------------------------------------------------------------------------------ | hydra | pkg://hydra.conf | | main | file:///cwd/conf | | schema | structured:// | ------------------------------------------------------------------------------------ Defaults Tree *************Defaults with choice as object (`site: fb`)
```yaml # config.yaml defaults: - site: fb - _self_ ``` gives ``` Hydra 1.3.2 =========== Installed Hydra Plugins *********************** ConfigSource: ------------- FileConfigSource ImportlibResourcesConfigSource StructuredConfigSource CompletionPlugin: ----------------- BashCompletion FishCompletion ZshCompletion Launcher: --------- BasicLauncher Sweeper: -------- BasicSweeper Config search path ****************** | Provider | Search path | ------------------------------------------------------------------------------------ | hydra | pkg://hydra.conf | | main | file:///cwd/conf | | schema | structured:// | ------------------------------------------------------------------------------------ Defaults Tree *************Defaults with multiple choices (`site: [fb, google]`)
```yaml # config.yaml defaults: - site: - fb - google - _self_ ``` gives ``` Hydra 1.3.2 =========== Installed Hydra Plugins *********************** ConfigSource: ------------- FileConfigSource ImportlibResourcesConfigSource StructuredConfigSource CompletionPlugin: ----------------- BashCompletion FishCompletion ZshCompletion Launcher: --------- BasicLauncher Sweeper: -------- BasicSweeper Config search path ****************** | Provider | Search path | ------------------------------------------------------------------------------------ | hydra | pkg://hydra.conf | | main | file:///cwd/conf | | schema | structured:// | ------------------------------------------------------------------------------------ Defaults Tree *************Defaults with choice as object and override (`site: fb` and `~site=fb`)
```yaml # config.yaml defaults: - site: fb - _self_ ``` gives ``` Hydra 1.3.2 =========== Installed Hydra Plugins *********************** ConfigSource: ------------- FileConfigSource ImportlibResourcesConfigSource StructuredConfigSource CompletionPlugin: ----------------- BashCompletion FishCompletion ZshCompletion Launcher: --------- BasicLauncher Sweeper: -------- BasicSweeper Config search path ****************** | Provider | Search path | ------------------------------------------------------------------------------------ | hydra | pkg://hydra.conf | | main | file:///cwd/conf | | schema | structured:// | ------------------------------------------------------------------------------------ Defaults Tree *************