facebookresearch / hydra

Hydra is a framework for elegantly configuring complex applications
https://hydra.cc
MIT License
8.84k stars 638 forks source link

Explicitly add a versioned dependency for path-to-regexp #2954

Closed Sanjay-Ganeshan closed 2 months ago

Sanjay-Ganeshan commented 2 months ago

We depend on path-to-regexp, through the webserver framework Express, which I think is coming from webpack or docusaurus.

Versions of path-to-regexp 0.2.0 < version < 1.9.0 have a security vulnerability. By explicitly specifying the version of path-to-regexp, yarn chooses the right versions for everything else.

Motivation

Address a security vulnerability

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Download nvm / node as needed (tested on node JS 20, Mac OS)

nvm use 20
npm install -g yarn

Then, install the website:

cd website
yarn

Last but not least, start the website on a local server, and browse it:

yarn start

It should work normally.

Related Issues and PRs

None