PR originally generated with gh actions-importer migrate circle-ci --target-url https://github.com/facebookresearch/hydra.git --output-dir migrate --circle-ci-project hydra
Added the following changes:
Removed the no longer used AWS and CIRCLE_CI key environment variables
Removed plugin only test logic, now we just always run all the tests - looks like there was some kind of logic to only run the pipeline tests in certain cases to handle permissions (discussion in https://github.com/facebookresearch/hydra/pull/2180) which no longer seem relevant since we're removing these tokens entirely
Fixed up setup steps to work correctly for linux, windows, and mac
Fixed the tests to work on windows properly
Added quotes around temp directory override since the windows directory contains ~ which messes up the parser without the quotes
Forced tests to use the C: drive
Forced tests to output in utf-8 (the github windows image seems to be ignoring the PYTHONIOENCODING env var
Note there's probably still some inefficiency in this setup but not a priority to improve it right now.
Test:
See CI signals. Note the CircleCI failure is expected and we'll disable it once this PR is approved.
Pipeline migrated from CircleCI :tada:
PR originally generated with
gh actions-importer migrate circle-ci --target-url https://github.com/facebookresearch/hydra.git --output-dir migrate --circle-ci-project hydraAdded the following changes:
~which messes up the parser without the quotesPYTHONIOENCODINGenv varNote there's probably still some inefficiency in this setup but not a priority to improve it right now.
Test: See CI signals. Note the CircleCI failure is expected and we'll disable it once this PR is approved.