search

facebookresearch / hydra

Hydra is a framework for elegantly configuring complex applications
https://hydra.cc
MIT License
8.84k stars 638 forks source link

Fix override str util function to handle new lines and quotes correctly #2974

Closed jesszzzz closed 1 month ago

jesszzzz commented 1 month ago

Motivation

There were some bugs in the original implementation of this function when it came to quotes and backslashes in strings. I've fixed them and added better round-trip tests.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tests pass (the one failure is also happening on master and seems circle ci related and we're moving off of circle ci anyway in https://github.com/facebookresearch/hydra/pull/2974

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax) https://github.com/facebookresearch/hydra/pull/2934

adrianloy commented 1 month ago

When will this be released? @Sanjay-Ganeshan