Closed AndRossi closed 5 years ago
Hi !
Thanks for your interest in my code :) I'm trying to keep this codebase as simple as possible as its main goal is reproduction of research result and readability.
The learn.py is more of a minimal working example than a real tool. I'd prefer to encourage people to re-use the models and / or optimizers in their own code. I'll close this issue for now and will leave people to use your implementation for saving and loading if they want to. If it turns out there is more demand for this, I will add it in.
Hi, thank you for developing these amazing models.
May I suggest you to make
learn.py
save the model in the filesystem during training? This way one could use a trained model for inference as well; e.g. for my research I am trying to extract deeper information from the model predictions, so I need to perform inference after the training is done.I have implemented the variation myself, and so far it seems to work. It is a tiny variation of course, but it may be useful to other developers so I'm sharing this here.
If you think it's a nice feature to have you can integrate the code to your repo, or otherwise feel free to just close this issue :)
Thanks again for your great work, and have a nice day!