Variable name mismatch - Githubissues

facebookresearch / mae

PyTorch implementation of MAE https//arxiv.org/abs/2111.06377

Other

7.2k stars 1.2k forks source link

Variable name mismatch #125

Open ariG23498 opened 1 year ago

ariG23498 commented 1 year ago

Hey folks,

It turns out that the x_masked in the following line should be x_unmasked according to the paper. https://github.com/facebookresearch/mae/blob/efb2a8062c206524e35e47d04501ed4f544c0ae8/models_mae.py#L140

I have also added a similar fix to the transformers library.

PR: https://github.com/huggingface/transformers/pull/18850