Bugfix in ModelTrainer.maybe_get_best_weights() and made the threshold for improvement configurable from ModelTrainer.train() - Githubissues

facebookresearch / mbrl-lib

Library for Model Based RL

MIT License

959 stars 158 forks source link

Bugfix in ModelTrainer.maybe_get_best_weights() and made the threshold for improvement configurable from ModelTrainer.train() #104

Closed jan1854 closed 3 years ago

jan1854 commented 3 years ago

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Fixes #102 and addresses https://github.com/facebookresearch/mbrl-lib/issues/102#issuecomment-875697175

How Has This Been Tested (if it applies)

I added a new test case in tests/core/test_common_utils.py

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

luisenp commented 3 years ago

Merged. Thanks for the fix!