search

facebookresearch / mbrl-lib

Library for Model Based RL
MIT License
952 stars 154 forks source link

[Feature Request] Support for Dreamers #143

Open veds12 opened 2 years ago

veds12 commented 2 years ago

🚀 Feature Request

Add support for Dreamer and Dreamerv2

Motivation

Dreamer and Dreamerv2 are important and current SOTA in mbrl. Few standard implementations are available for both Dreamer (rllib, author's implementation) and Dreamerv2 (author's implementation). Some good implementations include https://github.com/RajGhugare19/dreamerv2, https://github.com/juliusfrost/dreamer-pytorch and https://github.com/jurgisp/pydreamer

Pitch

Both Dreamer and Dreamerv2 can be written on top of planet

luisenp commented 2 years ago

Hi @veds12. This is definitely at the top of my list of priorities for MBRL-Lib! I hope we can roll out an implementation in the next few months, but It's taking longer than I'd like since I have other commitments.

natolambert commented 2 years ago

I would be interested in contributing @luisenp. Long time been on my list to study it.

veds12 commented 2 years ago

Thank you @luisenp and @natolambert ! @natolambert I would be interested in this as well. Please let me know (if / how) I can help :)

luisenp commented 2 years ago

That sounds great! How about setting a VC the 3 of us to coordinate this week? Does Friday work for you? If you are interested, send me an email and I'll send an invite to that address. @veds12 @natolambert

Rohan138 commented 2 years ago

Hi! Just wanted to check in on progress on this; I'd be interested in contributing as well.

luisenp commented 2 years ago

Hi @Rohan138. @veds12 opened a PR skeleton for this (#145), but there hasn't been a lot of progress lately, and I've been busy with other projects. Contributions are definitely welcome! I will also have more time after NeurIPS deadline to offer support/collaborate on this :)

Rohan138 commented 2 years ago

@luisenp Just opened a draft PR #151 ; mainly need to debug and clean up the dreamer loss calculation, then test it.

luisenp commented 2 years ago

Awesome! I'll take a look this week and give feedback. Thanks a lot for contributing to the library!

ManuelRios18 commented 2 years ago

151

This PR is intended to implement DreamerV2?

luisenp commented 2 years ago

Hi @ManuelRios18 that PR is intended to implement the original Dreamer.