changed path handling to be OS agnostic

MarcoKe commented 2 years ago

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Since Windows uses backslashes instead of forwardslashes, replacing parts of a path based on forwardslashes resulted in an error under Windows.

https://github.com/facebookresearch/mbrl-lib/issues/152

How Has This Been Tested (if it applies)

The changes were manually tested using Windows 10 and a VM with Ubuntu 20.04.

The test suite was executed using pytest and no new errors were found.

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests. (Some tests already did not pass with a fresh clone of the main branch. Those still do not pass with the changes of course.

luisenp commented 2 years ago

Hi @MarcoKe. Can you rebase on top of the latest changes to main? I fixed some import issues that are causing CI to fail. After that, we are good to merge. Thanks!

MarcoKe commented 2 years ago

Hi @MarcoKe. Can you rebase on top of the latest changes to main? I fixed some import issues that are causing CI to fail. After that, we are good to merge. Thanks!

Done. I also removed the unnecessary wrap in a Path object.

luisenp commented 2 years ago

Merging now, thanks a lot of the contribution, @MarcoKe!

facebookresearch / mbrl-lib