Include dict comprehension - Githubissues

facebookresearch / mbrl-lib

Library for Model Based RL

MIT License

952 stars 154 forks source link

Include dict comprehension #168

Closed boneyag closed 1 year ago

boneyag commented 1 year ago

Types of changes

Replaces invocation to dict constructor with dict comprehension

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

dict comprehension is faster than invoking the constructor with a list of tuples.

How Has This Been Tested (if it applies)

No additional tests required

Checklist

[x] The documentation is up-to-date with the changes I made - NA
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

luisenp commented 1 year ago

Thanks for the contribution! LGTM, but can you update to the latest main and commit again? I had to fix some errors caused by updates to one of the dependencies we use for CI.