Fix centering, scaling and clamping population in ICEMOptimizer.optimize - Githubissues

facebookresearch / mbrl-lib

Library for Model Based RL

MIT License

952 stars 154 forks source link

Fix centering, scaling and clamping population in ICEMOptimizer.optimize #174

Closed marbaga closed 1 year ago

marbaga commented 1 year ago

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Fixes https://github.com/facebookresearch/mbrl-lib/issues/172.

How Has This Been Tested (if it applies)

No additional test was added, default tests passed.

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CONTRIBUTING).
[x] All tests passed, and additional code has been covered with new tests.

luisenp commented 1 year ago

Thanks for the pull request! Looks good. Can you rebase on top of main, fixed some format errors that were breaking CI. Good to merge after that.