Remove Namespace hack - Githubissues

facebookresearch / metaseq

Repo for external large-scale work

MIT License

6.45k stars 723 forks source link

Remove Namespace hack #55

Open suchenzang opened 2 years ago

suchenzang commented 2 years ago

See: https://github.com/facebookresearch/metaseq/blob/9afea52f5988fcbfe6133591fc27dd56044bd4ea/metaseq/checkpoint_utils.py#L424-L425

Previous attempt at removing this hack broke generation, evals, and resuming training from checkpoint (namespaces were slipping through, despite conversion to omegaconf - need to track down where that happens).

suchenzang commented 2 years ago

This seems unrelated to this task - please open a separate issue tracking. For reference, we are using version 2.1.1 for omegaconf (should pin this version here too).