search

facebookresearch / mmbt

Supervised Multimodal Bitransformers for Classifying Images and Text
Other
243 stars 52 forks source link

Script for generating test_hard_gt.jsonl #10

Closed HireTheHero closed 3 years ago

HireTheHero commented 3 years ago

script/test_hard_gt.py and hard_gt_ids.jsonl for genarating test_hard_gt.jsonl , based on #6

HireTheHero commented 3 years ago

Hi @douwekiela , happy to hear your feedback. Will update the script accordingly and get back to you

HireTheHero commented 3 years ago

Hi @douwekiela , new commits should reflect your comments and pylint/flake8/black. Thanks again for your feedback, at the end the script gets much simpler.

Aware that one liner for writing test_hard_gt.jsonl is a bit longer than pep8 expectation, but left as it is for the moment since with a quick check only option to shorten the line is to make variable names too short, for which I think negative impact is stronger. More than happy to hear it if you have additional feedback on the script.