search

facebookresearch / mmf

A modular framework for vision & language multimodal research from Facebook AI Research (FAIR)
https://mmf.sh/
Other
5.46k stars 932 forks source link

[MMF] MultiDataLoader len property change if dataset is type Iterable #1195

Closed sisilmehta2000 closed 2 years ago

sisilmehta2000 commented 2 years ago

Summary: MultiDataLoader len property currently sets length of zero for datasets that are iterable. However that can be misleading since zero len is being used as proxy for an iterable dataset.

  1. Add a has_len() property to MultiDataLoader to check if it has len
  2. Return float("inf") as len if it has a iterable dataset

Differential Revision: D34024359

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D34024359

facebook-github-bot commented 2 years ago

This pull request has been reverted by 9321d1a3d9d03491ab765502995a3bb3f6300f06.

facebook-github-bot commented 2 years ago

This pull request has been reverted by 990a824ae0a7045d0b9837b7a1a847ce1b749ab3.