Use configurable loggers rather than swallowing print statements

facebookresearch / moco

PyTorch implementation of MoCo: https://arxiv.org/abs/1911.05722

MIT License

4.83k stars 794 forks source link

Use configurable loggers rather than swallowing print statements #50

Closed kmatzen closed 4 years ago

kmatzen commented 4 years ago

Just a nit, but print statements are used throughout the code rather than configurable loggers. Since the print builtin is overridden on processes other than process 0, this can be surprising to developers. Consider using python's logging module to make this configuration more standardized and clear.

KaimingHe commented 4 years ago

This repo aims to be a minimal revision on the PyTorch ImageNet training code for illustrating the MoCo idea. Improving and customizing the interface or software design is beyond the scope of this repo. Please feel free to branch and share your version.