facebookresearch / multiface

Hosts the Multiface dataset, which is a multi-view dataset of multiple identities performing a sequence of facial expressions.
Other
718 stars 50 forks source link

Typo in download_dataset.py #4

Closed TianyuDai closed 2 years ago

TianyuDai commented 2 years ago

Hi, Thank you for making the dataset public! I tried to download the mini-dataset following the instruction, but fell into an infinite loop. Should line 65 in download_dataset.py be if os.path.isfile("%s.checksum" % (tar_file))?

FreedomGu commented 2 years ago

I had the same issues in downloading mini-dataset as well.

FreedomGu commented 2 years ago

And seems like both of /path/to/mini-dataset and /path/to/dataset doesn't exists?

alexanderrichard commented 2 years ago

Apologies for the inconvenience. We will fix the bug asap.

vexilligera commented 2 years ago

And seems like both of /path/to/mini-dataset and /path/to/dataset doesn't exists?

Hi, that is for you to replace with the path to your downloaded dataset. Thank you.

cwuu commented 2 years ago

Hi, Thank you for making the dataset public! I tried to download the mini-dataset following the instruction, but fell into an infinite loop. Should line 65 in download_dataset.py be if os.path.isfile("%s.checksum" % (tar_file))?

Hi, Thanks for pointing this out. download_dataset.py is updated and added the condition to avoid possible infinite loop.