Add bike team pursuit benchmark (rewriting 1153)

facebookresearch / nevergrad

A Python toolbox for performing gradient-free optimization

https://facebookresearch.github.io/nevergrad/

MIT License

3.93k stars 352 forks source link

Add bike team pursuit benchmark (rewriting 1153) #1387

Closed teytaud closed 2 years ago

teytaud commented 2 years ago

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

See https://github.com/facebookresearch/nevergrad/pull/1153

How Has This Been Tested (if it applies)

Checklist

[x] The documentation is up-to-date with the changes I made.
[x] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[x] All tests passed, and additional code has been covered with new tests.

teytaud commented 2 years ago

I factorized quite a bit and added a simple test.

teytaud commented 2 years ago

@ryankroon could we have your opinion here ?

ryankroon commented 2 years ago

@ryankroon could we have your opinion here ?

Hi @teytaud and @jrapin, (A bit late now but..) I am happy with the code and all looks good. Furthermore, I thank you for helping me and completing the final changes / factorising so that my work could be merged - I was struggling a bit with this before. I also apologise for leaving this work in somewhat of a limbo... I always planned to come back to it at a later date, but I have been very busy the past few months with starting a new job among other commitments. Overall, I'm glad the work has been merged and I hope the it becomes a good benchmark problem. Thank you, Ryan