facebookresearch / nevergrad

A Python toolbox for performing gradient-free optimization
https://facebookresearch.github.io/nevergrad/
MIT License
3.93k stars 352 forks source link

bad PR with big exception because I don't get it #1398

Open teytaud opened 2 years ago

teytaud commented 2 years ago

Types of changes

Motivation and Context / Related issue

When running on crop_simulator ("python -m nevergrad.benchmark crop_simulator --num_workers=2 --plot") I got this error:

Error when applying Experiment: Experiment: MetaModel (dim=2, param=2hp:[ 0.35 35. ]) on Instance of Cr opSimulator(function_class='CropSimulator') with seed None: Traceback (most recent call last): File "/private/home/oteytaud/nevergradpr/nevergrad/benchmark/xpbase.py", line 196, in run self._run_with_error() File "/private/home/oteytaud/nevergradpr/nevergrad/benchmark/xpbase.py", line 274, in _run_with_error raise e File "/private/home/oteytaud/nevergradpr/nevergrad/benchmark/xpbase.py", line 270, in _run_with_error executor=executor, File "/private/home/oteytaud/nevergradpr/nevergrad/optimization/base.py", line 659, in minimize args = self.ask() File "/private/home/oteytaud/nevergradpr/nevergrad/optimization/base.py", line 469, in ask candidate = self._internal_ask_candidate() File "/private/home/oteytaud/nevergradpr/nevergrad/optimization/optimizerlib.py", line 1609, in _internal_ask_candidate data = learn_on_k_best(self.archive, sample_size) File "/private/home/oteytaud/nevergradpr/nevergrad/optimization/metamodel.py", line 84, in learn_on_k_best raise MetaModelFailure("huge meta-model optimum in learn_on_k_best.") nevergrad.optimization.metamodel.MetaModelFailure: huge meta-model optimum in learn_on_k_best.

I don't understand, because we should catch this.

How Has This Been Tested (if it applies)

"python -m nevergrad.benchmark crop_simulator --num_workers=2 --plot" does not break anymore.

Checklist