Closed mathuvu closed 2 years ago
I think this PR is super important but complicated for CircleCI because we are not allowed to do multiprocessing.... But we need to change this because of https://stackoverflow.com/questions/58919495/why-is-threadpoolexecutor-slower-than-for-loop)
Hi @mathuvu!
Thank you for your pull request.
We require contributors to sign our Contributor License Agreement, and yours needs attention.
You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
Types of changes
Motivation and Context / Related issue
ThreadPoolExecutor use only one thread for all task in async due to GIL lock (one interpreter = one thread). For CPU-bound function ProcessPoolExecutor circumvent this issue.
How Has This Been Tested (if it applies)
Checklist