[ X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Motivation and Context / Related issue
A bug in the RCWA code used in photonics. Luckily, this should not impact the values of the cost functions used in nevergrad. But for further developments, who knows. It's better to fix this now.
How Has This Been Tested (if it applies)
The numerical results have been compared to a reference code in matlab.
Checklist
[X ] The documentation is up-to-date with the changes I made.
[ X] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[ ] All tests passed, and additional code has been covered with new tests.
Types of changes
Motivation and Context / Related issue
A bug in the RCWA code used in photonics. Luckily, this should not impact the values of the cost functions used in nevergrad. But for further developments, who knows. It's better to fix this now.
How Has This Been Tested (if it applies)
The numerical results have been compared to a reference code in matlab.
Checklist