facebookresearch / nevergrad

A Python toolbox for performing gradient-free optimization

https://facebookresearch.github.io/nevergrad/

MIT License

3.95k stars 353 forks source link

Adding relative improvement as stopping criterion #1479

Open lolloconsoli opened 1 year ago

lolloconsoli commented 1 year ago

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

Adding the relative improvement as a stopping criterion callback to the ```base.Optimizer.minimize``` method #589

How Has This Been Tested (if it applies)

i took some parts from the script ```test_callbacks.py``` and run some tests with different thresholds, the thing seems to work properly. After i added the test function in an analogous format as the one done for ```test_duration_criterion``` ## Checklist

[ ] The documentation is up-to-date with the changes I made.
[ ] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[x ] All tests passed, and additional code has been covered with new tests.

facebook-github-bot commented 1 year ago

Hi @lolloconsoli!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

teytaud commented 1 year ago

Sounds like a very useful PR, thanks!!! For << nevergrad/optimization/base.py:11:0: W0611: Unused deepcopy imported from copy (unused-import) >> you can just remove this import.

For the other static error just do << black nevergrad >> and everything should be fine.

teytaud commented 1 year ago

<< FAILED nevergrad/optimization/test_callbacks.py::test_improvement_criterion - assert False

<=== for this, do you need help ?

lolloconsoli commented 1 year ago

hello, i think i can fix the unused import problem, but im new to the testing tool so i may need help for that im sorry..

teytaud commented 1 year ago

hello, i think i can fix the unused import problem, but im new to the testing tool so i may need help for that im sorry..

Can you do "black nevergrad" and remove the import and push again ? This should make things clearer.

lolloconsoli commented 1 year ago

hello, i think i can fix the unused import problem, but im new to the testing tool so i may need help for that im sorry..

Can you do "black nevergrad" and remove the import and push again ? This should make things clearer.

i did as you suggested, but now there is another test that has not passed. I think the code i wrote test_improvement_criterion is wrong, and i may need a bit of a guidance for that im sorry