Update sphere.py -- add pooling and max_pooling - Githubissues

facebookresearch / nevergrad

A Python toolbox for performing gradient-free optimization

https://facebookresearch.github.io/nevergrad/

MIT License

3.89k stars 349 forks source link

Update sphere.py -- add pooling and max_pooling #1596

Closed mzameshina closed 4 months ago

mzameshina commented 4 months ago

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

How Has This Been Tested (if it applies)

Checklist

[ ] The documentation is up-to-date with the changes I made.
[ ] I have read the CONTRIBUTING document and completed the CLA (see CLA).
[ ] All tests passed, and additional code has been covered with new tests.

teytaud commented 4 months ago

Does it run ? This does not work as Torch is not in the dependencies. I recommend not using torch, as it would imply a big dependency.

Also you need black.