search

facebookresearch / nle

The NetHack Learning Environment
Other
939 stars 114 forks source link

Add option to save ttyrec files every "M" episodes #260

Closed dmadeka closed 2 years ago

dmadeka commented 2 years ago

@heiner Solves #256

dmadeka commented 2 years ago

@heiner so weird - this passed all the checks

heiner commented 2 years ago

@heiner so weird - this passed all the checks

Is this about the test failing in https://github.com/facebookresearch/nle/pull/259/checks?check_run_id=3667649209 ? That's a flake, showing up only in a small percentage of cases (due to the NetHack RNG and perhaps also the random actions supplied).

heiner commented 2 years ago

BTW it would be better for this PR to not contain the changes from #259. Some git-fu would make that possible.

dmadeka commented 2 years ago

Yeah - I remember you mentioning you squash commits, so I can rebase and drop the plot commits

dmadeka commented 2 years ago

@heiner Done! sorry - i forgot you guys squash commits

heiner commented 2 years ago

Merging this into a dev branch for further refinement of the API.

heiner commented 2 years ago

@dmadeka please follow in #304 re: the exact API of your proposal here.

dmadeka commented 2 years ago

@heiner Will get back to this after the COLT deadline!