facebookresearch / nle

The NetHack Learning Environment
Other
940 stars 114 forks source link

Race condition in environment settings #287

Closed heiner closed 2 years ago

heiner commented 2 years ago

🐛 Bug

Currently, we set environment variables before init and before reset. In the case of HACKDIR, this is problematic as there's a race when several instances of NLE get reset or initialized simultaneously.

On top of that, using environment variables is a bit ugly in our case.

We should create an nle_settings struct that contains these and funnel them through.

heiner commented 2 years ago

Fixed in #291.