search

facebookresearch / nle

The NetHack Learning Environment
Other
940 stars 114 forks source link

Fix field initialization order breaking clang #293

Closed xmakro closed 2 years ago

facebook-github-bot commented 2 years ago

Hi @makroiss!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

heiner commented 2 years ago

Hey Makro! Thanks for your contribution to NLE!

Could you please sign the CLA (might require approval from your employer) and run clang-format, version 11 on your code or otherwise fix https://github.com/facebookresearch/nle/runs/4445827015?check_suite_focus=true?