search

facebookresearch / nle

The NetHack Learning Environment
Other
940 stars 114 forks source link

Fix _underscore access, rename Nethack variable as `nethack`. #303

Closed heiner closed 2 years ago

heiner commented 2 years ago

Fixes #273.

One reason this matters more than one would assume is that gym envs wrappers tend to forward non-underscore access but will typically fail with ._underscore access. This happened e.g. for the 0.21 release which auto-wrapped every env.

Also a bit more cleanup.

samvelyan commented 2 years ago

Seems like this PR brakes the play.py script which uses env._actions. This is a small fix.

heiner commented 2 years ago

Seems like this PR brakes the play.py script which uses env._actions. This is a small fix.

Good catch, thanks! Fixed in https://github.com/facebookresearch/nle/pull/308