search

facebookresearch / nle

The NetHack Learning Environment
Other
940 stars 114 forks source link

Populate database using the files in xlogfile #321

Closed cdmatters closed 2 years ago

cdmatters commented 2 years ago

ttyrecname= when writing ttyrecs.

cdmatters commented 2 years ago

Prior to #319 , we populated the dataset's database by matching up rows in the xlogfile to the the reset suffix in nle.<process>.<reset>.ttyrec<version>.bz2.

This was clearly prone to mistakes when an episode was terminated (eg: hitting reset() before done is True), which would introduce offset errors. Now that the file has been added to the xlogfile, we can directly use this information to populate the db, removing this error.