search

facebookresearch / nle

The NetHack Learning Environment
Other
937 stars 114 forks source link

Set the terminal emulator to by default not wrap extra long lines, #330

Closed cdmatters closed 2 years ago

cdmatters commented 2 years ago

thereby taking a crop of the larger terminal screen.

cdmatters commented 2 years ago

This was tested manually: BEFORE Screenshot 2022-06-16 at 14 48 15

AFTER Screenshot 2022-06-16 at 14 46 20

heiner commented 2 years ago

I think this is what the distinction of rendered terminal size vs cropped terminal size was for? But this here works too.

cdmatters commented 2 years ago

I think this is what the distinction of rendered terminal size vs cropped terminal size was for? But this here works too.

This is precisely what that was for (I mentioned this to @tscmoo), but this method is a little more memory efficient, and involves fewer parameters.