search

facebookresearch / nle

The NetHack Learning Environment
Other
937 stars 114 forks source link

Use sensible fcontext default stack. #336

Closed heiner closed 2 years ago

facebook-github-bot commented 2 years ago

Hi @heiner!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

heiner commented 2 years ago

The test failure on all Linuxes is related to https://github.com/septag/deboost.context/issues/4.

cdmatters commented 2 years ago

While the default stack method seems like a saner way to do things, is a resolution on this PR necessary? I'd have thought unless we overflow again, probably not, but have not properly investigated this... If so, shall I close and open an Issue?

heiner commented 2 years ago

Answer to your question heavily depends on your definition of "necessary".

cdmatters commented 2 years ago

lol i suppose so: i guess what i meant is - my understanding is that this PR aimed to use a default stack size instead of one arbititrarily chosen by us, but this is broken upstream. to my mind this PR is good practice but mainly cosmetic in that it shouldn't really affect most peoples running of NLE post pr #334 . is there something i'm missing in the understanding of this issue that means NLE could break unexpectedly in future, and actually is more pressing to resolve?

heiner commented 2 years ago

No you're right. It could break if the stack gets very large but is unlikely to at this point. We can close this PR for now.