search

facebookresearch / nle

The NetHack Learning Environment
Other
937 stars 114 forks source link

Git clone fails with "unable to checkout working tree" on windows #341

Closed alexholdenmiller closed 1 year ago

alexholdenmiller commented 2 years ago

🐛 Bug

Colons in ttyrecs filenames creates errors on windows.

To Reproduce

$ git clone https://github.com/facebookresearch/nle.git
Cloning into 'nle'...
remote: Enumerating objects: 78058, done.
remote: Counting objects: 100% (352/352), done.
remote: Compressing objects: 100% (192/192), done.
remote: Total 78058 (delta 195), reused 241 (delta 160), pack-reused 77706
Receiving objects: 100% (78058/78058), 105.88 MiB | 27.52 MiB/s, done.
Resolving deltas: 100% (62374/62374), done.
error: invalid path 'nle/tests/altorg/FlamingKetchup/2019-07-25.22:03:29.ttyrec.bz2'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

also fails from the github program on windows.

cdmatters commented 2 years ago

Hey @alexholdenmiller, will change this - though NLE in general will run into some problems with windows!

cdmatters commented 1 year ago

Fixed this issue in #343