search

facebookresearch / nle

The NetHack Learning Environment
Other
939 stars 113 forks source link

Prevent use of macro __warn_unused_result__ for M1 Macs, fixing Issue… #344

Closed cdmatters closed 1 year ago

cdmatters commented 1 year ago

… #340.

heiner commented 1 year ago

Alternative would be to cherry-pick this: https://github.com/NetHack/NetHack/commit/13028143af8fbdc453ee261c957eac8617da9da4

cdmatters commented 1 year ago

Think cherry-pick is the better way to do this.

samvelyan commented 1 year ago

I can confirm that now the following successfully installs nle on my M1 Chip Mac

pip install git+https://github.com/facebookresearch/nle.git@eric/M1-URWARN
cdmatters commented 1 year ago

I found the cherry-pick didnt seem to work on Mika's macbook, so reverted the change. Will investigate on my M1, but might just merge this later.

heiner commented 1 year ago

If so, this is a good opportunity to have your code in upstream NH :)