Open BartekCupial opened 1 year ago
Incorrect syntax in db.delete_dataset.
Steps to reproduce the behavior:
db.create(dbfilename) populate_db.add_nledata_directory(dataset_path, dataset_name, dbfilename) with db.db(filename=dbfilename, rw=True) as conn: db.delete_dataset(dataset_name, conn)
Changing lines 165-166 in https://github.com/facebookresearch/nle/blob/main/nle/dataset/db.py
conn.execute("DELETE datasets WHERE dataset_name=?", (dataset_name,)) conn.execute("DELETE roots WHERE dataset_name=?", (dataset_name,))
to
conn.execute("DELETE FROM datasets WHERE dataset_name=?", (dataset_name,)) conn.execute("DELETE FROM roots WHERE dataset_name=?", (dataset_name,))
should fix the issue.
🐛 Bug
Incorrect syntax in db.delete_dataset.
To Reproduce
Steps to reproduce the behavior:
Fix proposition
Changing lines 165-166 in https://github.com/facebookresearch/nle/blob/main/nle/dataset/db.py
to
should fix the issue.