search

facebookresearch / nle

The NetHack Learning Environment
Other
937 stars 114 forks source link

update pybind11 to v2.11.1 #362

Closed apowers313 closed 8 months ago

apowers313 commented 1 year ago

Fixes #361 by updating the pybind11 module to the v2.11.1 tag.

facebook-github-bot commented 1 year ago

Hi @apowers313!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

cdmatters commented 1 year ago

You'll have to approve the contributor license agreement.

apowers313 commented 1 year ago

CLA signed

jsuarez5341 commented 8 months ago

@cdmatters Can this be merged? Would like to ship NLE in a container with 3.11 and this is blocking

heiner commented 8 months ago

@samvelyan might be able to approve.

jsuarez5341 commented 8 months ago

Awesome! Looks like the automated build is failing, any chance of an updated pypi package?

jsuarez5341 commented 8 months ago

@samvelyan Any chance of updating the pip package?

jsuarez5341 commented 8 months ago

@samvelyan Any word on this? Shipping NLE source in our containers for now, would be nice to have the pip package