Dataset Build Instructions

axelbr commented 2 years ago

Maybe let's continue this discussion (#11) here.

I ran into some issues during the dataset construction:

[ ] The files/scripts referenced in the README were moved to the scripts/ directory.
[ ] There are dependencies needed to run waymo_scenario_construction.py, which are not mentioned in environment.yml: tensorflow and waymo-open-dataset-tf-2-x-0.
[ ] Running make_solvable_files.py does not accept command line arguments (maybe because of hydra?)
[ ] Running make_solvable_files.py gives me this error: PermissionError: [Errno 13] Permission denied: '/checkpoint' . After some debugging I figured out that the paths in cfgs/config.yaml should be relative paths. But I first have to look more into hydra.
[ ] After fixing the paths, running make_solvable_files.py leads to the following error: omegaconf.errors.ConfigKeyError: Key 'start_time' is not in struct. I guess it should be cfg['scenario']['start_time].

eugenevinitsky commented 2 years ago

Oof okay that's a fair number of issues. I'll open up a PR cleaning these particular ones up but in the meantime (so you're not blocked) you can also download the files directly from the dropbox if that's more convenient.

eugenevinitsky commented 2 years ago

Thank you for your help in pointing these errors out!

eugenevinitsky commented 2 years ago

If you wait ~30 minutes I should have a PR resolving these issues for you but you are of course welcome to work them out yourself.

axelbr commented 2 years ago

Oh, I overlooked somehow that the construction progress is not mandatory. :smile: No problem.

eugenevinitsky commented 2 years ago

Taking a bit longer than I would have liked to debug all of this so thanks for your patience but I hope the pre-built dataset is working for you!

axelbr commented 2 years ago

No need to hurry.

eugenevinitsky commented 2 years ago

Okay, I think the master branch should have resolved all the errors you listed! Hope that helps if you try to create the dataset.

axelbr commented 2 years ago

thanks for your help. i will try it on the weekend.

eugenevinitsky commented 2 years ago

Cool! I'm going to close this for now, reopen it if you find issues? However, you don't have to check it out, the dataset is constructed for you and this step is optional.

facebookresearch / nocturne

Dataset Build Instructions #16