search

facebookresearch / nocturne

A data-driven, fast driving simulator for multi-agent coordination under partial observability.
MIT License
259 stars 29 forks source link

[Bug] #40

Closed LifGorg closed 2 years ago

LifGorg commented 2 years ago

Operating system

Ubuntu 2204

Bug description

Hi there,

I encountered an error when executing nocturne/examples/create_env.py.

After the execution in a terminal, nothing showed up.

Before that, I strictly followed instructions and made sure every step was just the same as the readme file. And I've changed the DATA_ FOLDER to the place where the valid and train data are stored.

Any help would be greatly appreciated! Thanks in advance

Steps to reproduce

strictly followed instructions and made sure every step was just the same as the readme file

Relevant log output

eugenevinitsky commented 2 years ago

Yep! Simple fix, you need to go to cfgs/config.py and change the DATA_FOLDER to point to the path where you've downloaded the json files. Does that fix it?

eugenevinitsky commented 2 years ago

Did you do all the steps in the Downloading the Dataset section?

LifGorg commented 2 years ago

Did you do all the steps in the Downloading the Dataset section?

Thanks for your reply~ I think I've changed the DATA_FOLDER path and made sure I followed every step until now My current issue is that after the execution of create_env.py, nothing showed up

LifGorg commented 2 years ago

Did you do all the steps in the Downloading the Dataset section?

And I noticed that in the "Installing Nocturne" section, the git clone link is outdated(https://github.com/nathanlct/nocturne.git). The current one is https://github.com/facebookresearch/nocturne.git

eugenevinitsky commented 2 years ago

Thank you for that catch, just fixed it! create_env.py is not intended to ouput anything, it's just a code example of how you construct an environment and step and use it. What were you expecting to show up? This is useful info for how we change that example.

LifGorg commented 2 years ago

Oh, didn't know that. I thought it would pop up a window like the Carla simulator where we can have a peek at its visual

eugenevinitsky commented 2 years ago

Ah no, we should add an example that does that! I'm out tomorrow but I'll probably write one on Monday. We do have a rendering example that will make movies of what happened though.

eugenevinitsky commented 2 years ago

Can I close this issue or do you have something outstanding? I'll ping you when the rendering window example is merged.

LifGorg commented 2 years ago

Thanks for the help! Yeah I don't have further problems~